empathicqubit/AppleWin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
AppleWin/source
History
Andrea 70540bd6dc Fix the following errors reported by VS2017 Code Analysis. (#414) 
* Fix the following errors reported by VS2017 Code Analysis.

applewin\source\applewin.cpp(761): warning C6385: Reading invalid data from '"Disk Image"':  the readable size is '11' bytes, but '21' bytes may be read.
applewin\source\debugger\debug.cpp(6624): warning C6386: Buffer overrun while writing to 'sName':  the writable size is '31' bytes, but '32' bytes might be written.
applewin\source\debugger\debugger_display.cpp(3715): warning C6053: The prior call to 'strncpy' might not zero-terminate string 'sText'.
applewin\source\log.cpp(42): warning C6053: The prior call to '_vsnprintf' might not zero-terminate string 'output'.
applewin\source\debugger\debug.cpp(2759): warning C6011: Dereferencing NULL pointer 'pFont'.
applewin\source\debugger\debugger_symbols.cpp(243): warning C6053: The prior call to '_tcsncpy' might not zero-terminate string 'pText'.
applewin\source\diskimagehelper.cpp(1132): warning C6053: The prior call to '_tcsncpy' might not zero-terminate string 'pszExt'.
applewin\source\diskimagehelper.cpp(1141): warning C6053: The prior call to '_tcsncpy' might not zero-terminate string 'szFilename'.
applewin\source\parallelprinter.cpp(242): warning C6053: The prior call to '_tcsncpy' might not zero-terminate string 'g_szPrintFilename'.

The one about RegSetValue(), according to Microsoft

https://msdn.microsoft.com/en-us/library/windows/desktop/ms724922(v=vs.85).aspx

the last argument cbData is ignored, so I set it to 0, as in some cases was anyway wrong (see "DiskImage").


Signed-off-by: Andrea Odetti <mariofutire@gmail.com>

* Use sizeof() rather than hardcoded value.
Fix one more case on non terminated string.


Signed-off-by: Andrea Odetti <mariofutire@gmail.com>
2018-02-24 15:24:37 +00:00
..
CommonVICE Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Configuration Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
CPU Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Debugger Fix the following errors reported by VS2017 Code Analysis. (#414) 2018-02-24 15:24:37 +00:00
Tfe Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Z80VICE Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
6821.cpp More header refactoring 2014-08-14 18:03:12 +01:00
6821.h Manual merge from master @ c798157 2016-03-21 23:48:02 +00:00
Applewin.cpp Fix the following errors reported by VS2017 Code Analysis. (#414) 2018-02-24 15:24:37 +00:00
Applewin.h Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
AY8910.cpp Support polling of Mockingboard's & Phasor's 6522 IFR.Timer1 (#496) 2017-10-21 18:47:22 +01:00
AY8910.h Manual merge from master @ c798157 2016-03-21 23:48:02 +00:00
Common.h Full-screen: Hide mouse cursor after 2s of inactivity (#504) 2017-10-28 21:59:48 +01:00
CPU.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
CPU.h Support for #384: 2017-02-25 22:32:46 +00:00
Disk.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Disk.h Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
DiskDefs.h DiskFormat: tweaks and fixed some TODOs in comments 2018-01-20 17:18:24 +00:00
DiskFormatTrack.cpp Removed extra local var and updated DOS 3.2 INIT comment 2018-02-23 22:39:51 +00:00
DiskFormatTrack.h Improve logging and fix asserts for DOS 3.2 INIT (#537) 2018-02-15 21:54:15 +00:00
DiskImage.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
DiskImage.h git merge --squash GH125-ProDOS-Format. Fix for disk formatting #125, #196, #338: 2018-01-14 18:01:22 +00:00
DiskImageHelper.cpp Fix the following errors reported by VS2017 Code Analysis. (#414) 2018-02-24 15:24:37 +00:00
DiskImageHelper.h Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
DiskLog.h Improve logging and fix asserts for DOS 3.2 INIT (#537) 2018-02-15 21:54:15 +00:00
Frame.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Frame.h Frame.cpp: Remove redundant, commented out and if 0 code, mostly relating to the old full-screen implementation 2017-10-11 19:18:53 +01:00
Harddisk.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Harddisk.h Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Joystick.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Joystick.h 1.26.3.0: Apply bounds and error checking for the joystick configuration (fixes #434) 2017-07-03 21:48:21 +01:00
Keyboard.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Keyboard.h Manual merge from master @ c798157 2016-03-21 23:48:02 +00:00
Log.cpp Fix the following errors reported by VS2017 Code Analysis. (#414) 2018-02-24 15:24:37 +00:00
Log.h Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
Memory.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Memory.h Save-state: Fix for when SSC's expansion ROM is active and PC is running in this space (GH#486) 2017-09-22 22:23:13 +01:00
Mockingboard.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Mockingboard.h Support Mockingboard/Phasor when polling IFR.Timer1 (#496) 2017-10-24 22:28:22 +01:00
MouseInterface.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
MouseInterface.h Full-screen: Hide mouse cursor after 2s of inactivity (#504) 2017-10-28 21:59:48 +01:00
NoSlotClock.cpp Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
NoSlotClock.h Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
NTSC.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
NTSC.h Support floating-bus in full-speed mode (#508, #519, #532) 2018-02-02 20:19:48 +00:00
NTSC_CharSet.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
NTSC_CharSet.h Small tidy-up for NTSC_CharSet.cpp, and fix-up the VS2008/2013/2015 projects 2016-07-26 19:14:06 +01:00
ParallelPrinter.cpp Fix the following errors reported by VS2017 Code Analysis. (#414) 2018-02-24 15:24:37 +00:00
ParallelPrinter.h Manual merge from master @ c798157 2016-03-21 23:48:02 +00:00
Peripheral_Clock_Generic.cpp Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
Peripheral_Clock_Generic.h Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
Peripheral_Clock_ThunderClockPlus.cpp Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
Pravets.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Pravets.h Manual merge from master @ c798157 2016-03-21 23:48:02 +00:00
Registry.cpp Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
Registry.h Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Riff.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Riff.h Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
SAM.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
SAM.h Manual merge from master @ c798157 2016-03-21 23:48:02 +00:00
SaveState.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
SaveState.h Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
SaveState_Structs_common.h Manual merge from master @ c798157 2016-03-21 23:48:02 +00:00
SaveState_Structs_v1.h Manual merge from master @ c798157 2016-03-21 23:48:02 +00:00
SerialComms.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
SerialComms.h SSC: Added -modem switch (for dcd,dsr,dtr) and removed invert switches (#386) 2017-03-23 21:36:26 +00:00
SoundCore.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
SoundCore.h Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
Speaker.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Speaker.h Removed unsupported PC speaker sound types 2016-09-07 22:20:15 +01:00
Speech.cpp Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
Speech.h Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
SSI263Phonemes.h Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
StdAfx.cpp Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
StdAfx.h Added VS2017 support. 2017-06-10 20:39:25 +01:00
Tape.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Tape.h Remove the top-level AppleWin folder 2014-05-23 22:59:02 +01:00
Video.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
Video.h Video.cpp: remove redundant code 2017-07-06 21:36:56 +01:00
YamlHelper.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
YamlHelper.h git merge --squash GH125-ProDOS-Format. Fix for disk formatting #125, #196, #338: 2018-01-14 18:01:22 +00:00
z80emu.cpp Changes to ease code compilation in gcc. (#541) 2018-02-24 15:12:40 +00:00
z80emu.h Manual merge from master @ c798157 2016-03-21 23:48:02 +00:00