Formatting (#362)

* adds editorconfig to ensure coherent code style
* formats according to editorconfig

BetterJoyForCemu/.editorconfig

@@ -0,0 +1,119 @@
+# To learn more about .editorconfig see https://aka.ms/editorconfigdocs
+###############################
+# Core EditorConfig Options   #
+###############################
+root = true
+# All files
+[*]
+indent_style = tab
+# Code files
+[*.{cs,csx,vb,vbx}]
+indent_size = 4
+end_of_line = crlf
+insert_final_newline = true
+charset = utf-8-bom
+###############################
+# .NET Coding Conventions     #
+###############################
+[*.{cs,vb}]
+# Organize usings
+dotnet_sort_system_directives_first = true
+# this. preferences
+dotnet_style_qualification_for_field = false:silent
+dotnet_style_qualification_for_property = false:silent
+dotnet_style_qualification_for_method = false:silent
+dotnet_style_qualification_for_event = false:silent
+# Language keywords vs BCL types preferences
+dotnet_style_predefined_type_for_locals_parameters_members = true:silent
+dotnet_style_predefined_type_for_member_access = true:silent
+# Parentheses preferences
+dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent
+dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent
+dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent
+dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent
+# Modifier preferences
+dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent
+dotnet_style_readonly_field = true:suggestion
+# Expression-level preferences
+dotnet_style_object_initializer = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_explicit_tuple_names = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true:silent
+dotnet_style_prefer_inferred_tuple_names = true:suggestion
+dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
+dotnet_style_prefer_auto_properties = true:silent
+dotnet_style_prefer_conditional_expression_over_assignment = true:silent
+dotnet_style_prefer_conditional_expression_over_return = true:silent
+###############################
+# Naming Conventions          #
+###############################
+# Style Definitions
+dotnet_naming_style.pascal_case_style.capitalization             = pascal_case
+# Use PascalCase for constant fields  
+dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols  = constant_fields
+dotnet_naming_rule.constant_fields_should_be_pascal_case.style    = pascal_case_style
+dotnet_naming_symbols.constant_fields.applicable_kinds            = field
+dotnet_naming_symbols.constant_fields.applicable_accessibilities  = *
+dotnet_naming_symbols.constant_fields.required_modifiers          = const
+###############################
+# C# Coding Conventions       #
+###############################
+[*.cs]
+# var preferences
+csharp_style_var_for_built_in_types = true:silent
+csharp_style_var_when_type_is_apparent = true:silent
+csharp_style_var_elsewhere = true:silent
+# Expression-bodied members
+csharp_style_expression_bodied_methods = false:silent
+csharp_style_expression_bodied_constructors = false:silent
+csharp_style_expression_bodied_operators = false:silent
+csharp_style_expression_bodied_properties = true:silent
+csharp_style_expression_bodied_indexers = true:silent
+csharp_style_expression_bodied_accessors = true:silent
+# Pattern matching preferences
+csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
+csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
+# Null-checking preferences
+csharp_style_throw_expression = true:suggestion
+csharp_style_conditional_delegate_call = true:suggestion
+# Modifier preferences
+csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:suggestion
+# Expression-level preferences
+csharp_prefer_braces = true:silent
+csharp_style_deconstructed_variable_declaration = true:suggestion
+csharp_prefer_simple_default_expression = true:suggestion
+csharp_style_pattern_local_over_anonymous_function = true:suggestion
+csharp_style_inlined_variable_declaration = true:suggestion
+###############################
+# C# Formatting Rules         #
+###############################
+# New line preferences
+csharp_new_line_before_open_brace = false
+csharp_new_line_before_else = false
+csharp_new_line_before_catch = false
+csharp_new_line_before_finally = false
+csharp_new_line_before_members_in_object_initializers = true
+csharp_new_line_before_members_in_anonymous_types = true
+csharp_new_line_between_query_expression_clauses = true
+# Indentation preferences
+csharp_indent_case_contents = true
+csharp_indent_switch_labels = true
+csharp_indent_labels = flush_left
+# Space preferences
+csharp_space_after_cast = false
+csharp_space_after_keywords_in_control_flow_statements = true
+csharp_space_between_method_call_parameter_list_parentheses = false
+csharp_space_between_method_declaration_parameter_list_parentheses = false
+csharp_space_between_parentheses = false
+csharp_space_before_colon_in_inheritance_clause = true
+csharp_space_after_colon_in_inheritance_clause = true
+csharp_space_around_binary_operators = before_and_after
+csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
+csharp_space_between_method_call_name_and_opening_parenthesis = false
+csharp_space_between_method_call_empty_parameter_list_parentheses = false
+# Wrapping preferences
+csharp_preserve_single_line_statements = true
+csharp_preserve_single_line_blocks = true

BetterJoyForCemu/Config.cs

@@ -1,9 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace BetterJoyForCemu {
 	public static class Config { // stores dynamic configuration, including

BetterJoyForCemu/Controller/OutputControllerDualShock4.cs

@@ -1,17 +1,9 @@
-using Nefarius.ViGEm.Client.Targets;
+using System;
+using Nefarius.ViGEm.Client.Targets;
 using Nefarius.ViGEm.Client.Targets.DualShock4;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-using System.Windows.Forms.VisualStyles;
-using System.Xml.Serialization;
 
-namespace BetterJoyForCemu.Controller
-{
-    public enum DpadDirection
-    {
+namespace BetterJoyForCemu.Controller {
+	public enum DpadDirection {
 		None,
 		Northwest,
 		West,
@@ -23,8 +15,7 @@ namespace BetterJoyForCemu.Controller
 		North,
 	}
 
-    public struct OutputControllerDualShock4InputState
-    {
+	public struct OutputControllerDualShock4InputState {
 		public bool triangle;
 		public bool circle;
 		public bool cross;
@@ -83,8 +74,7 @@ namespace BetterJoyForCemu.Controller
 		}
 	}
 
-    public class OutputControllerDualShock4
-    {
+	public class OutputControllerDualShock4 {
 		private IDualShock4Controller controller;
 
 		private OutputControllerDualShock4InputState current_state;
@@ -93,26 +83,22 @@ namespace BetterJoyForCemu.Controller
 		public delegate void DualShock4FeedbackReceivedEventHandler(DualShock4FeedbackReceivedEventArgs e);
 		public event DualShock4FeedbackReceivedEventHandler FeedbackReceived;
 
-        public OutputControllerDualShock4()
-        {
+		public OutputControllerDualShock4() {
 			controller = Program.emClient.CreateDualShock4Controller();
 			Init();
 		}
 
-        public OutputControllerDualShock4(ushort vendor_id, ushort product_id)
-        {
+		public OutputControllerDualShock4(ushort vendor_id, ushort product_id) {
 			controller = Program.emClient.CreateDualShock4Controller(vendor_id, product_id);
 			Init();
 		}
 
-        private void Init()
-        {
+		private void Init() {
 			controller.AutoSubmitReport = false;
 			controller.FeedbackReceived += FeedbackReceivedRcv;
 		}
 
-        private void FeedbackReceivedRcv(object _sender, DualShock4FeedbackReceivedEventArgs e)
-        {
+		private void FeedbackReceivedRcv(object _sender, DualShock4FeedbackReceivedEventArgs e) {
 			FeedbackReceived(e);
 		}
 
@@ -124,10 +110,8 @@ namespace BetterJoyForCemu.Controller
 			controller.Disconnect();
 		}
 
-        public bool UpdateInput(OutputControllerDualShock4InputState new_state)
-        {
-            if(current_state.IsEqual(new_state))
-            {
+		public bool UpdateInput(OutputControllerDualShock4InputState new_state) {
+			if (current_state.IsEqual(new_state)) {
 				return false;
 			}
 
@@ -136,8 +120,7 @@ namespace BetterJoyForCemu.Controller
 			return true;
 		}
 
-        private void DoUpdateInput(OutputControllerDualShock4InputState new_state)
-        {
+		private void DoUpdateInput(OutputControllerDualShock4InputState new_state) {
 			controller.SetButtonState(DualShock4Button.Triangle, new_state.triangle);
 			controller.SetButtonState(DualShock4Button.Circle, new_state.circle);
 			controller.SetButtonState(DualShock4Button.Cross, new_state.cross);
@@ -172,10 +155,8 @@ namespace BetterJoyForCemu.Controller
 			current_state = new_state;
 		}
 
-        private DualShock4DPadDirection MapDPadDirection(DpadDirection dPad)
-        {
-            switch(dPad)
-            {
+		private DualShock4DPadDirection MapDPadDirection(DpadDirection dPad) {
+			switch (dPad) {
 				case DpadDirection.None: return DualShock4DPadDirection.None;
 				case DpadDirection.North: return DualShock4DPadDirection.North;
 				case DpadDirection.Northeast: return DualShock4DPadDirection.Northeast;

BetterJoyForCemu/Controller/OutputControllerXbox360.cs

@@ -1,11 +1,8 @@
 using Nefarius.ViGEm.Client.Targets;
 using Nefarius.ViGEm.Client.Targets.Xbox360;
-using System.Web.UI;
 
-namespace BetterJoyForCemu.Controller
-{
-    public struct OutputControllerXbox360InputState
-    {
+namespace BetterJoyForCemu.Controller {
+	public struct OutputControllerXbox360InputState {
 		// buttons
 		public bool thumb_stick_left;
 		public bool thumb_stick_right;
@@ -40,8 +37,7 @@ namespace BetterJoyForCemu.Controller
 		public byte trigger_left;
 		public byte trigger_right;
 
-        public bool IsEqual(OutputControllerXbox360InputState other)
-        {
+		public bool IsEqual(OutputControllerXbox360InputState other) {
 			bool buttons = thumb_stick_left == other.thumb_stick_left
 				&& thumb_stick_right == other.thumb_stick_right
 				&& y == other.y
@@ -71,8 +67,7 @@ namespace BetterJoyForCemu.Controller
 		}
 	}
 
-    public class OutputControllerXbox360
-    {
+	public class OutputControllerXbox360 {
 		private IXbox360Controller xbox_controller;
 		private OutputControllerXbox360InputState current_state;
 
@@ -80,32 +75,27 @@ namespace BetterJoyForCemu.Controller
 
 		public event Xbox360FeedbackReceivedEventHandler FeedbackReceived;
 
-        public OutputControllerXbox360()
-        {
+		public OutputControllerXbox360() {
 			xbox_controller = Program.emClient.CreateXbox360Controller();
 			Init();
 		}
 
-        public OutputControllerXbox360(ushort vendor_id, ushort product_id)
-        {
+		public OutputControllerXbox360(ushort vendor_id, ushort product_id) {
 			xbox_controller = Program.emClient.CreateXbox360Controller(vendor_id, product_id);
 			Init();
 		}
 
-        private void Init()
-        {
+		private void Init() {
 			xbox_controller.FeedbackReceived += FeedbackReceivedRcv;
 			xbox_controller.AutoSubmitReport = false;
 		}
 
-        private void FeedbackReceivedRcv(object _sender, Xbox360FeedbackReceivedEventArgs e)
-        {
+		private void FeedbackReceivedRcv(object _sender, Xbox360FeedbackReceivedEventArgs e) {
 			FeedbackReceived(e);
 		}
 
 		public bool UpdateInput(OutputControllerXbox360InputState new_state) {
-            if (current_state.IsEqual(new_state))
-            {
+			if (current_state.IsEqual(new_state)) {
 				return false;
 			}
 
@@ -114,19 +104,16 @@ namespace BetterJoyForCemu.Controller
 			return true;
 		}
 
-        public void Connect()
-        {
+		public void Connect() {
 			xbox_controller.Connect();
 			DoUpdateInput(new OutputControllerXbox360InputState());
 		}
 
-        public void Disconnect()
-        {
+		public void Disconnect() {
 			xbox_controller.Disconnect();
 		}
 
-        private void DoUpdateInput(OutputControllerXbox360InputState new_state)
-        {
+		private void DoUpdateInput(OutputControllerXbox360InputState new_state) {
 			xbox_controller.SetButtonState(Xbox360Button.LeftThumb, new_state.thumb_stick_left);
 			xbox_controller.SetButtonState(Xbox360Button.RightThumb, new_state.thumb_stick_right);
 

BetterJoyForCemu/Joycon.cs

@@ -1,21 +1,15 @@
 using System;
 using System.Collections.Generic;
+using System.Configuration;
 using System.Diagnostics;
 using System.Linq;
 using System.Net.NetworkInformation;
 using System.Numerics;
-using System.Configuration;
 using System.Threading;
-using System.Threading.Tasks;
-
-using Nefarius.ViGEm.Client;
-using Nefarius.ViGEm.Client.Targets;
-using Nefarius.ViGEm.Client.Targets.Xbox360;
-using System.Runtime.InteropServices;
 using System.Windows.Forms;
-using WindowsInput;
-using Nefarius.ViGEm.Client.Targets.DualShock4;
 using BetterJoyForCemu.Controller;
+using Nefarius.ViGEm.Client.Targets.DualShock4;
+using Nefarius.ViGEm.Client.Targets.Xbox360;
 
 namespace BetterJoyForCemu {
 	public class Joycon {

BetterJoyForCemu/Program.cs

@@ -1,24 +1,20 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-
-using System.Threading;
-using System.Runtime.InteropServices;
-using System.Timers;
-
-using System.Net.NetworkInformation;
-using System.Diagnostics;
-
-using static BetterJoyForCemu.HIDapi;
-using Nefarius.ViGEm.Client;
-using System.Net;
 using System.Configuration;
-using System.Net.Http;
+using System.Diagnostics;
 using System.IO;
-using System.Windows.Forms;
-
+using System.Linq;
+using System.Net;
+using System.Net.Http;
+using System.Net.NetworkInformation;
+using System.Runtime.InteropServices;
 using System.ServiceProcess;
+using System.Text;
+using System.Threading;
+using System.Timers;
+using System.Windows.Forms;
+using Nefarius.ViGEm.Client;
+using static BetterJoyForCemu.HIDapi;
 
 namespace BetterJoyForCemu {
 	public class JoyconManager {

BetterJoyForCemu/UpdServer.cs

@@ -1,14 +1,10 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
-using Force.Crc32;
+using System.Configuration;
 using System.Net;
 using System.Net.NetworkInformation;
 using System.Net.Sockets;
-using System.Configuration;
+using Force.Crc32;
 
 namespace BetterJoyForCemu {
 	class UdpServer {