empathicqubit/Mesen-SX
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GBC: Fixed GDMA timing (setup should only be done once, not once per block)

Browse source
This commit is contained in:
Sour 2020-07-03 11:08:31 -04:00
parent ff1848857c
commit af49013e92
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Core/GbDmaController.cpp
View file

@ -86,6 +86,10 @@ void GbDmaController::WriteCgb(uint16_t addr, uint8_t value)
_state.CgbHdmaRunning = false; _state.CgbHdmaRunning = false;
_state.CgbHdmaDone = true; _state.CgbHdmaDone = true;
} else { } else {
//4 cycles for setup
_memoryManager->Exec();
_memoryManager->Exec();
do { do {
ProcessDmaBlock(); ProcessDmaBlock();
} while(_state.CgbDmaLength != 0x7F); } while(_state.CgbDmaLength != 0x7F);
@ -109,6 +113,10 @@ void GbDmaController::WriteCgb(uint16_t addr, uint8_t value)
void GbDmaController::ProcessHdma() void GbDmaController::ProcessHdma()
{ {
if(_state.CgbHdmaRunning) { if(_state.CgbHdmaRunning) {
//4 cycles for setup
_memoryManager->Exec();
_memoryManager->Exec();
ProcessDmaBlock(); ProcessDmaBlock();
} }
} }
@ -116,10 +124,6 @@ void GbDmaController::ProcessHdma()
void GbDmaController::ProcessDmaBlock() void GbDmaController::ProcessDmaBlock()
{ {
//TODO check invalid dma sources/etc. //TODO check invalid dma sources/etc.
//4 cycles for setup
_memoryManager->Exec();
_memoryManager->Exec();
for(int i = 0; i < 16; i++) { for(int i = 0; i < 16; i++) {
uint16_t dst = 0x8000 | ((_state.CgbDmaDest + i) & 0x1FFF); uint16_t dst = 0x8000 | ((_state.CgbDmaDest + i) & 0x1FFF);