empathicqubit/Mesen-SX
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

PPU: VRAM writes should always increment the address (even outside vblank/forced blank)

Browse source
This commit is contained in:
Sour 2019-06-26 16:39:57 -04:00
parent 0b40b7a437
commit dafe4a2856
1 changed files with 11 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
Core/Ppu.cpp
View file

@ -1527,14 +1527,13 @@ void Ppu::Write(uint32_t addr, uint8_t value)
case 0x2118:
//VMDATAL - VRAM Data Write low byte
if(!_forcedVblank && _scanline < _vblankStart) {
//Invalid VRAM access - can't write VRAM outside vblank/force blank
return;
if(_scanline >= _vblankStart || _forcedVblank) {
//Only write the value if in vblank or forced blank (writes to VRAM outside vblank/forced blank are not allowed)
_console->ProcessPpuWrite(GetVramAddress() << 1, value, SnesMemoryType::VideoRam);
_vram[GetVramAddress() << 1] = value;
}
_console->ProcessPpuWrite(GetVramAddress() << 1, value, SnesMemoryType::VideoRam);
_vram[GetVramAddress() << 1] = value;
//The VRAM address is incremented even outside of vblank/forced blank
if(!_vramAddrIncrementOnSecondReg) {
_vramAddress = (_vramAddress + _vramIncrementValue) & 0x7FFF;
}
@ -1542,14 +1541,13 @@ void Ppu::Write(uint32_t addr, uint8_t value)
case 0x2119:
//VMDATAH - VRAM Data Write high byte
if(!_forcedVblank && _scanline < _vblankStart) {
//Invalid VRAM access - can't write VRAM outside vblank/force blank
return;
if(_scanline >= _vblankStart || _forcedVblank) {
//Only write the value if in vblank or forced blank (writes to VRAM outside vblank/forced blank are not allowed)
_console->ProcessPpuWrite((GetVramAddress() << 1) + 1, value, SnesMemoryType::VideoRam);
_vram[(GetVramAddress() << 1) + 1] = value;
}
_console->ProcessPpuWrite((GetVramAddress() << 1) + 1, value, SnesMemoryType::VideoRam);
_vram[(GetVramAddress() << 1) + 1] = value;
//The VRAM address is incremented even outside of vblank/forced blank
if(_vramAddrIncrementOnSecondReg) {
_vramAddress = (_vramAddress + _vramIncrementValue) & 0x7FFF;
}