empathicqubit/Mesen-SX
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CPU: Fixed MVN/MVP instructions using the wrong src/dest banks

Browse source
This commit is contained in:
Sour 2019-02-20 20:00:59 -05:00
parent 011caf951c
commit f75db1b297
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Core/Cpu.Instructions.cpp
View file

@ -614,8 +614,8 @@ Move operations
****************/ ****************/
void Cpu::MVN() void Cpu::MVN()
{ {
uint32_t srcBank = (_operand << 16) & 0xFF0000; uint32_t destBank = (_operand << 16) & 0xFF0000;
uint32_t destBank = (_operand << 8) & 0xFF0000; uint32_t srcBank = (_operand << 8) & 0xFF0000;
while(_state.A != 0xFFFF) { while(_state.A != 0xFFFF) {
uint8_t value = ReadData(srcBank | _state.X); uint8_t value = ReadData(srcBank | _state.X);
Write(destBank | _state.Y, value); Write(destBank | _state.Y, value);
@ -628,8 +628,8 @@ void Cpu::MVN()
void Cpu::MVP() void Cpu::MVP()
{ {
uint32_t srcBank = (_operand << 16) & 0xFF0000; uint32_t destBank = (_operand << 16) & 0xFF0000;
uint32_t destBank = (_operand << 8) & 0xFF0000; uint32_t srcBank = (_operand << 8) & 0xFF0000;
while(_state.A != 0xFFFF) { while(_state.A != 0xFFFF) {
uint8_t value = ReadData(srcBank | _state.X); uint8_t value = ReadData(srcBank | _state.X);
Write(destBank | _state.Y, value); Write(destBank | _state.Y, value);

2
Core/DisassemblyInfo.cpp
View file

@ -54,7 +54,7 @@ void DisassemblyInfo::GetDisassembly(string &out, uint32_t memoryAddr)
case AddrMode::AbsLng: str.Write(operand); break; case AddrMode::AbsLng: str.Write(operand); break;
case AddrMode::AbsLngJmp: str.Write(operand); break; case AddrMode::AbsLngJmp: str.Write(operand); break;
case AddrMode::Acc: break; case AddrMode::Acc: break;
case AddrMode::BlkMov: str.Write(operand[0], operand[1], " <- ", operand[2], operand[3]); break; //TODO case AddrMode::BlkMov: str.Write(operand[1], operand[2], " -> ", operand[3], operand[4]); break;
case AddrMode::DirIdxIndX: str.Write('(', operand, ",X)"); break; case AddrMode::DirIdxIndX: str.Write('(', operand, ",X)"); break;
case AddrMode::DirIdxX: str.Write(operand, ",X"); break; case AddrMode::DirIdxX: str.Write(operand, ",X"); break;
case AddrMode::DirIdxY: str.Write(operand, ",Y"); break; case AddrMode::DirIdxY: str.Write(operand, ",Y"); break;