empathicqubit/Mesen-X
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Debugger: Fixed crashes with TBL files when unknown characters are present in the TBL file (e.g because it was not UTF-8 encoded)

Browse source
This commit is contained in:
Sour 2018-09-05 20:51:44 -04:00
parent e995c66927
commit 8019e70483
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
GUI.NET/Debugger/HexBox/TblByteCharConverter.cs
View file

@ -78,7 +78,9 @@ namespace Be.Windows.Forms
do {
match = false;
foreach(string key in _stringList) {
if(text.StartsWith(key)) {
//Without an ordinal comparison, it's possible for an empty string to "StartsWith" a non-empty string (e.g replacement char U+FFFD)
//This causes a crash here (because key.Length > text.Length)
if(text.StartsWith(key, StringComparison.Ordinal)) {
bytes.AddRange(_reverseTblRules[key].GetBytes());
text = text.Substring(key.Length);
match = true;