diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationItem.java b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationItem.java index bdb327bfb7..b84045a0eb 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationItem.java +++ b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationItem.java @@ -88,7 +88,6 @@ import org.thoughtcrime.securesms.conversation.colors.Colorizer; import org.thoughtcrime.securesms.database.AttachmentDatabase; import org.thoughtcrime.securesms.database.DatabaseFactory; import org.thoughtcrime.securesms.database.MessageDatabase; -import org.thoughtcrime.securesms.database.documents.IdentityKeyMismatch; import org.thoughtcrime.securesms.database.model.MediaMmsMessageRecord; import org.thoughtcrime.securesms.database.model.MessageRecord; import org.thoughtcrime.securesms.database.model.MmsMessageRecord; @@ -727,14 +726,6 @@ public final class ConversationItem extends RelativeLayout implements BindableCo bodyText.setText(StringUtil.trim(styledText)); bodyText.setVisibility(View.VISIBLE); } - - if (!messageRecord.isOutgoing()) { - if (!messageRecord.isMms()) { - ViewUtil.setTopMargin(bodyText, readDimen(R.dimen.message_bubble_content_top_padding)); - } else { - ViewUtil.setTopMargin(bodyText, readDimen(R.dimen.message_bubble_text_top_padding)); - } - } } private void setMediaAttributes(@NonNull MessageRecord messageRecord, @@ -1171,6 +1162,10 @@ public final class ConversationItem extends RelativeLayout implements BindableCo if (mediaThumbnailStub.resolved()) { ViewUtil.setTopMargin(mediaThumbnailStub.get(), readDimen(R.dimen.message_bubble_top_padding)); + } else if (startOfCluster && !current.isOutgoing() && groupThread) { + ViewUtil.setTopMargin(quoteView, readDimen(R.dimen.message_bubble_quote_negative_margin)); + } else { + ViewUtil.setTopMargin(quoteView, readDimen(R.dimen.message_bubble_top_padding)); } if (linkPreviewStub.resolved() && !hasBigImageLinkPreview(current)) { @@ -1181,13 +1176,8 @@ public final class ConversationItem extends RelativeLayout implements BindableCo quoteView.dismiss(); } - int topMargin = (current.isOutgoing() || !startOfCluster || !groupThread) ? 0 : readDimen(R.dimen.message_bubble_content_top_padding); if (mediaThumbnailStub.resolved()) { - ViewUtil.setTopMargin(mediaThumbnailStub.get(), topMargin); - } - - if (linkPreviewStub.resolved()) { - ViewUtil.setTopMargin(linkPreviewStub.get(), topMargin); + ViewUtil.setTopMargin(mediaThumbnailStub.get(), 0); } } } diff --git a/app/src/main/res/layout/conversation_item_received_multimedia.xml b/app/src/main/res/layout/conversation_item_received_multimedia.xml index a71123c6db..49c3b639a8 100644 --- a/app/src/main/res/layout/conversation_item_received_multimedia.xml +++ b/app/src/main/res/layout/conversation_item_received_multimedia.xml @@ -73,6 +73,7 @@ android:layout_marginStart="@dimen/message_bubble_horizontal_padding" android:layout_marginEnd="@dimen/message_bubble_horizontal_padding" android:layout_marginTop="@dimen/message_bubble_top_padding" + android:layout_marginBottom="4dp" android:orientation="horizontal" android:visibility="gone" tools:visibility="visible"> @@ -95,7 +96,7 @@ android:id="@+id/quote_view" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_marginTop="@dimen/message_bubble_content_top_padding" + android:layout_marginTop="@dimen/message_bubble_top_padding" android:layout_marginStart="6dp" android:layout_marginEnd="6dp" android:visibility="gone" @@ -109,38 +110,34 @@ android:layout_width="@dimen/media_bubble_default_dimens" android:layout_height="wrap_content" android:layout="@layout/conversation_item_received_shared_contact" - android:layout_marginTop="@dimen/message_bubble_content_top_padding" + android:layout_marginTop="@dimen/message_bubble_top_padding" android:visibility="gone" /> + android:layout="@layout/conversation_item_received_thumbnail" /> + android:layout="@layout/conversation_item_received_sticker" /> + android:layout="@layout/conversation_item_received_link_preview" /> - - - - + android:layout="@layout/conversation_item_received_revealable" /> + + + + + + + - + android:orientation="vertical"> - + + + + + - + android:orientation="vertical"> - + + + + + - + android:orientation="vertical"> - + + + + 4dp 12dp 6dp + -3dp 32dp 7dp 24dp