empathicqubit/Signal-Android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Check action mode is still valid.

Browse source 
Due to support library bug, onActionItemClicked can be called after finish/onDestroyActionMode so we can check for that by checking if our reference to the action mode is still valid.

Fixes #8891
This commit is contained in:
Alan Evans 2019-06-27 15:44:05 -04:00 • committed by GitHub
parent c089d6cd43
commit 0f3de6c979
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/org/thoughtcrime/securesms/conversation/ConversationFragment.java
View file

@ -1054,6 +1054,8 @@ public class ConversationFragment extends Fragment
@Override @Override
public boolean onActionItemClicked(ActionMode mode, MenuItem item) { public boolean onActionItemClicked(ActionMode mode, MenuItem item) {
if (actionMode == null) return false;
switch(item.getItemId()) { switch(item.getItemId()) {
case R.id.menu_context_copy: case R.id.menu_context_copy:
handleCopyMessage(getListAdapter().getSelectedItems()); handleCopyMessage(getListAdapter().getSelectedItems());