From 1046265d23ca33c753a0257cd28c81cfa4335fc5 Mon Sep 17 00:00:00 2001 From: Alex Hart Date: Tue, 11 Oct 2022 10:35:38 -0300 Subject: [PATCH] Fix receipt handling issue for stories. --- .../securesms/messages/MessageContentProcessor.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/messages/MessageContentProcessor.java b/app/src/main/java/org/thoughtcrime/securesms/messages/MessageContentProcessor.java index 54a6c26b9d..5a7c396318 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/messages/MessageContentProcessor.java +++ b/app/src/main/java/org/thoughtcrime/securesms/messages/MessageContentProcessor.java @@ -2536,21 +2536,18 @@ public final class MessageContentProcessor { @NonNull SignalServiceReceiptMessage message, @NonNull Recipient senderRecipient) { - boolean shouldOnlyProcessStories = Stories.isFeatureFlagEnabled() && !SignalStore.storyValues().isFeatureDisabled() && !TextSecurePreferences.isReadReceiptsEnabled(context); - - if (!TextSecurePreferences.isReadReceiptsEnabled(context) && !shouldOnlyProcessStories) { + if (!TextSecurePreferences.isReadReceiptsEnabled(context)) { log("Ignoring viewed receipts for IDs: " + Util.join(message.getTimestamps(), ", ")); return; } - log(TAG, "Processing viewed receipts. Sender: " + senderRecipient.getId() + ", Device: " + content.getSenderDevice() + ", Only Stories: " + shouldOnlyProcessStories + ", Timestamps: " + Util.join(message.getTimestamps(), ", ")); + log(TAG, "Processing viewed receipts. Sender: " + senderRecipient.getId() + ", Device: " + content.getSenderDevice() + ", Timestamps: " + Util.join(message.getTimestamps(), ", ")); List ids = Stream.of(message.getTimestamps()) .map(t -> new SyncMessageId(senderRecipient.getId(), t)) .toList(); - Collection unhandled = shouldOnlyProcessStories ? SignalDatabase.mmsSms().incrementViewedStoryReceiptCounts(ids, content.getTimestamp()) - : SignalDatabase.mmsSms().incrementViewedReceiptCounts(ids, content.getTimestamp()); + Collection unhandled = SignalDatabase.mmsSms().incrementViewedReceiptCounts(ids, content.getTimestamp()); Set handled = new HashSet<>(ids); handled.removeAll(unhandled);