From 18436dc3be811c13ae12d971cdbf3df2b3aa6220 Mon Sep 17 00:00:00 2001 From: Michael Herbig Date: Thu, 21 May 2015 01:15:48 -0400 Subject: [PATCH] Fix context leak from lingering RecipientModifiedListener. Because ContactSelectionListItem is used as a RecipientModifiedListener, it leaks its context (NewConversationActivity/PushContactSelectionActivity), which can lead to OOM crashes. Closes #3214 // FREEBIE --- .../securesms/contacts/ContactSelectionListItem.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/org/thoughtcrime/securesms/contacts/ContactSelectionListItem.java b/src/org/thoughtcrime/securesms/contacts/ContactSelectionListItem.java index 5e979b73f9..3f9a9092de 100644 --- a/src/org/thoughtcrime/securesms/contacts/ContactSelectionListItem.java +++ b/src/org/thoughtcrime/securesms/contacts/ContactSelectionListItem.java @@ -107,6 +107,7 @@ public class ContactSelectionListItem extends RelativeLayout implements Recipien @Override public void onModified(final Recipient recipient) { if (this.recipient == recipient) { + recipient.removeListener(this); this.contactPhotoImage.post(new Runnable() { @Override public void run() {