empathicqubit/Signal-Android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Use stable ids on conversation list.

Browse source 
Fixes #10853
This commit is contained in:
Alan Evans 2021-01-29 18:50:16 -04:00 • committed by Greyson Parrelli
parent 701e43c13d
commit 2447601219
1 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
app/src/main/java/org/thoughtcrime/securesms/conversationlist/ConversationListAdapter.java
View file

@ -12,7 +12,6 @@ import androidx.recyclerview.widget.DiffUtil;
import androidx.recyclerview.widget.ListAdapter; import androidx.recyclerview.widget.ListAdapter;
import androidx.recyclerview.widget.RecyclerView; import androidx.recyclerview.widget.RecyclerView;
import org.signal.core.util.logging.Log;
import org.signal.paging.PagingController; import org.signal.paging.PagingController;
import org.thoughtcrime.securesms.BindableConversationListItem; import org.thoughtcrime.securesms.BindableConversationListItem;
import org.thoughtcrime.securesms.R; import org.thoughtcrime.securesms.R;
@ -58,6 +57,8 @@ class ConversationListAdapter extends ListAdapter<Conversation, RecyclerView.Vie
this.glideRequests = glideRequests; this.glideRequests = glideRequests;
this.onConversationClickListener = onConversationClickListener; this.onConversationClickListener = onConversationClickListener;
this.setHasStableIds(true);
} }
@Override @Override
@ -170,6 +171,19 @@ class ConversationListAdapter extends ListAdapter<Conversation, RecyclerView.Vie
return super.getItem(position); return super.getItem(position);
} }
@Override
public long getItemId(int position) {
Conversation item = getItem(position);
switch (item.getType()) {
case THREAD: return item.getThreadRecord().getThreadId();
case PINNED_HEADER: return -1;
case UNPINNED_HEADER: return -2;
case ARCHIVED_FOOTER: return -3;
default: throw new AssertionError();
}
}
public void setPagingController(@Nullable PagingController pagingController) { public void setPagingController(@Nullable PagingController pagingController) {
this.pagingController = pagingController; this.pagingController = pagingController;
} }