diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index ad93e46ac0..64a2fcdb51 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -1323,7 +1323,7 @@ - + diff --git a/app/src/main/java/org/thoughtcrime/securesms/ApplicationContext.java b/app/src/main/java/org/thoughtcrime/securesms/ApplicationContext.java index b2392ddb40..676711c4c9 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/ApplicationContext.java +++ b/app/src/main/java/org/thoughtcrime/securesms/ApplicationContext.java @@ -17,7 +17,6 @@ package org.thoughtcrime.securesms; import android.content.Context; -import android.os.Build; import androidx.annotation.NonNull; import androidx.annotation.Nullable; @@ -49,7 +48,6 @@ import org.thoughtcrime.securesms.dependencies.ApplicationDependencyProvider; import org.thoughtcrime.securesms.emoji.EmojiSource; import org.thoughtcrime.securesms.emoji.JumboEmoji; import org.thoughtcrime.securesms.gcm.FcmFetchManager; -import org.thoughtcrime.securesms.gcm.FcmJobService; import org.thoughtcrime.securesms.jobs.AccountConsistencyWorkerJob; import org.thoughtcrime.securesms.jobs.CheckServiceReachabilityJob; import org.thoughtcrime.securesms.jobs.DownloadLatestEmojiDataJob; @@ -61,7 +59,6 @@ import org.thoughtcrime.securesms.jobs.MultiDeviceContactUpdateJob; import org.thoughtcrime.securesms.jobs.PnpInitializeDevicesJob; import org.thoughtcrime.securesms.jobs.PreKeysSyncJob; import org.thoughtcrime.securesms.jobs.ProfileUploadJob; -import org.thoughtcrime.securesms.jobs.PushNotificationReceiveJob; import org.thoughtcrime.securesms.jobs.RefreshSvrCredentialsJob; import org.thoughtcrime.securesms.jobs.RetrieveProfileJob; import org.thoughtcrime.securesms.jobs.RetrieveRemoteAnnouncementsJob; @@ -71,7 +68,7 @@ import org.thoughtcrime.securesms.keyvalue.KeepMessagesDuration; import org.thoughtcrime.securesms.keyvalue.SignalStore; import org.thoughtcrime.securesms.logging.CustomSignalProtocolLogger; import org.thoughtcrime.securesms.logging.PersistentLogger; -import org.thoughtcrime.securesms.messageprocessingalarm.MessageProcessReceiver; +import org.thoughtcrime.securesms.messageprocessingalarm.RoutineMessageFetchReceiver; import org.thoughtcrime.securesms.migrations.ApplicationMigrations; import org.thoughtcrime.securesms.mms.GlideApp; import org.thoughtcrime.securesms.mms.SignalGlideComponents; @@ -405,7 +402,7 @@ public class ApplicationContext extends MultiDexApplication implements AppForegr DirectoryRefreshListener.schedule(this); LocalBackupListener.schedule(this); RotateSenderCertificateListener.schedule(this); - MessageProcessReceiver.startOrUpdateAlarm(this); + RoutineMessageFetchReceiver.startOrUpdateAlarm(this); if (BuildConfig.PLAY_STORE_DISABLED) { UpdateApkRefreshListener.schedule(this); diff --git a/app/src/main/java/org/thoughtcrime/securesms/messageprocessingalarm/MessageProcessReceiver.java b/app/src/main/java/org/thoughtcrime/securesms/messageprocessingalarm/RoutineMessageFetchReceiver.java similarity index 86% rename from app/src/main/java/org/thoughtcrime/securesms/messageprocessingalarm/MessageProcessReceiver.java rename to app/src/main/java/org/thoughtcrime/securesms/messageprocessingalarm/RoutineMessageFetchReceiver.java index 7b0db71271..2bd4a405bf 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/messageprocessingalarm/MessageProcessReceiver.java +++ b/app/src/main/java/org/thoughtcrime/securesms/messageprocessingalarm/RoutineMessageFetchReceiver.java @@ -24,11 +24,12 @@ import java.util.Locale; import java.util.Optional; /** - * On received message, runs a job to poll for messages. + * A receiver that is scheduled via alarm to run at a remotely-configurable interval to fetch messages from the service. + * Basically an extra reliability thing that helps poke the system to fetch messages more often. */ -public final class MessageProcessReceiver extends BroadcastReceiver { +public final class RoutineMessageFetchReceiver extends BroadcastReceiver { - private static final String TAG = Log.tag(MessageProcessReceiver.class); + private static final String TAG = Log.tag(RoutineMessageFetchReceiver.class); public static final String BROADCAST_ACTION = "org.thoughtcrime.securesms.action.PROCESS_MESSAGES"; @@ -68,9 +69,9 @@ public final class MessageProcessReceiver extends BroadcastReceiver { } public static void startOrUpdateAlarm(@NonNull Context context) { - Intent alarmIntent = new Intent(context, MessageProcessReceiver.class); + Intent alarmIntent = new Intent(context, RoutineMessageFetchReceiver.class); - alarmIntent.setAction(MessageProcessReceiver.BROADCAST_ACTION); + alarmIntent.setAction(RoutineMessageFetchReceiver.BROADCAST_ACTION); PendingIntent pendingIntent = PendingIntent.getBroadcast(context, 123, alarmIntent, PendingIntentFlags.updateCurrent()); AlarmManager alarmManager = (AlarmManager) context.getSystemService(Context.ALARM_SERVICE); diff --git a/app/src/main/java/org/thoughtcrime/securesms/util/FeatureFlags.java b/app/src/main/java/org/thoughtcrime/securesms/util/FeatureFlags.java index 19850bc845..64d590dda7 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/util/FeatureFlags.java +++ b/app/src/main/java/org/thoughtcrime/securesms/util/FeatureFlags.java @@ -17,8 +17,7 @@ import org.thoughtcrime.securesms.dependencies.ApplicationDependencies; import org.thoughtcrime.securesms.groups.SelectionLimits; import org.thoughtcrime.securesms.jobs.RemoteConfigRefreshJob; import org.thoughtcrime.securesms.keyvalue.SignalStore; -import org.thoughtcrime.securesms.messageprocessingalarm.MessageProcessReceiver; -import org.thoughtcrime.securesms.notifications.Configuration; +import org.thoughtcrime.securesms.messageprocessingalarm.RoutineMessageFetchReceiver; import org.whispersystems.signalservice.api.RemoteConfigResult; import java.io.IOException; @@ -268,7 +267,7 @@ public final class FeatureFlags { * desired test state. */ private static final Map FLAG_CHANGE_LISTENERS = new HashMap() {{ - put(MESSAGE_PROCESSOR_ALARM_INTERVAL, change -> MessageProcessReceiver.startOrUpdateAlarm(ApplicationDependencies.getApplication())); + put(MESSAGE_PROCESSOR_ALARM_INTERVAL, change -> RoutineMessageFetchReceiver.startOrUpdateAlarm(ApplicationDependencies.getApplication())); }}; private static final Map REMOTE_VALUES = new TreeMap<>();