empathicqubit/Signal-Android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Do not attempt to create link previews for .onion links.

Browse source
This commit is contained in:
Greyson Parrelli 2020-08-17 10:27:26 -04:00
parent 086b708cf7
commit 3f7dd21186
2 changed files with 25 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
app/src/main/java/org/thoughtcrime/securesms/linkpreview/LinkPreviewUtil.java
View file

@ -11,6 +11,7 @@ import android.text.style.URLSpan;
import android.text.util.Linkify; import android.text.util.Linkify;
import com.annimon.stream.Stream; import com.annimon.stream.Stream;
import com.google.android.collect.Sets;
import org.thoughtcrime.securesms.stickers.StickerUrl; import org.thoughtcrime.securesms.stickers.StickerUrl;
import org.thoughtcrime.securesms.util.Util; import org.thoughtcrime.securesms.util.Util;
@ -21,6 +22,7 @@ import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Set;
import java.util.regex.Matcher; import java.util.regex.Matcher;
import java.util.regex.Pattern; import java.util.regex.Pattern;
@ -37,6 +39,8 @@ public final class LinkPreviewUtil {
private static final Pattern FAVICON_PATTERN = Pattern.compile("<\\s*link[^>]*rel\\s*=\\s*\".*icon.*\"[^>]*>"); private static final Pattern FAVICON_PATTERN = Pattern.compile("<\\s*link[^>]*rel\\s*=\\s*\".*icon.*\"[^>]*>");
private static final Pattern FAVICON_HREF_PATTERN = Pattern.compile("href\\s*=\\s*\"([^\"]*)\""); private static final Pattern FAVICON_HREF_PATTERN = Pattern.compile("href\\s*=\\s*\"([^\"]*)\"");
private static final Set<String> INVALID_TOP_LEVEL_DOMAINS = Sets.newHashSet("onion");
/** /**
* @return All whitelisted URLs in the source text. * @return All whitelisted URLs in the source text.
*/ */
@ -72,11 +76,16 @@ public final class LinkPreviewUtil {
Matcher matcher = DOMAIN_PATTERN.matcher(url); Matcher matcher = DOMAIN_PATTERN.matcher(url);
if (matcher.matches()) { if (matcher.matches()) {
String domain = matcher.group(2); String domain = matcher.group(2);
String cleanedDomain = domain.replaceAll("\\.", ""); String cleanedDomain = domain.replaceAll("\\.", "");
String topLevelDomain = parseTopLevelDomain(domain);
return ALL_ASCII_PATTERN.matcher(cleanedDomain).matches() || boolean validCharacters = ALL_ASCII_PATTERN.matcher(cleanedDomain).matches() ||
ALL_NON_ASCII_PATTERN.matcher(cleanedDomain).matches(); ALL_NON_ASCII_PATTERN.matcher(cleanedDomain).matches();
boolean validTopLevelDomain = !INVALID_TOP_LEVEL_DOMAINS.contains(topLevelDomain);
return validCharacters && validTopLevelDomain;
} else { } else {
return false; return false;
} }
@ -127,6 +136,17 @@ public final class LinkPreviewUtil {
return new OpenGraph(openGraphTags, htmlTitle, faviconUrl); return new OpenGraph(openGraphTags, htmlTitle, faviconUrl);
} }
private static @Nullable String parseTopLevelDomain(@NonNull String domain) {
int periodIndex = domain.lastIndexOf(".");
if (periodIndex >= 0 && periodIndex < domain.length() - 1) {
return domain.substring(periodIndex + 1);
} else {
return null;
}
}
public static final class OpenGraph { public static final class OpenGraph {
private final Map<String, String> values; private final Map<String, String> values;

1
app/src/test/java/org/thoughtcrime/securesms/linkpreview/LinkPreviewUtilTest_isLegal.java
View file

@ -28,6 +28,7 @@ public class LinkPreviewUtilTest_isLegal {
{ "кц.com", false }, { "кц.com", false },
{ "http://asĸ.com", false }, { "http://asĸ.com", false },
{ "http://foo.кц.рф", false }, { "http://foo.кц.рф", false },
{ "https://abcdefg.onion", false },
{ "", false } { "", false }
}); });
} }