empathicqubit/Signal-Android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Improve logging in base identity store.

Browse source
This commit is contained in:
Greyson Parrelli 2022-04-26 09:12:43 -04:00 • committed by Cody Henthorne
parent 9505c3d070
commit 4635a77fbc
1 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
app/src/main/java/org/thoughtcrime/securesms/crypto/storage/SignalBaseIdentityKeyStore.java
View file

@ -116,7 +116,7 @@ public class SignalBaseIdentityKeyStore {
if (recipient.hasServiceId()) { if (recipient.hasServiceId()) {
cache.save(recipient.requireServiceId().toString(), recipientId, identityKey, verifiedStatus, firstUse, timestamp, nonBlockingApproval); cache.save(recipient.requireServiceId().toString(), recipientId, identityKey, verifiedStatus, firstUse, timestamp, nonBlockingApproval);
} else { } else {
Log.w(TAG, "[saveIdentity] No serviceId for " + recipient.getId()); Log.w(TAG, "[saveIdentity] No serviceId for " + recipient.getId(), new Throwable());
} }
} }
@ -157,7 +157,11 @@ public class SignalBaseIdentityKeyStore {
IdentityStoreRecord record = cache.get(recipient.requireServiceId().toString()); IdentityStoreRecord record = cache.get(recipient.requireServiceId().toString());
return Optional.ofNullable(record).map(r -> r.toIdentityRecord(recipient.getId())); return Optional.ofNullable(record).map(r -> r.toIdentityRecord(recipient.getId()));
} else { } else {
Log.w(TAG, "[getIdentityRecord] No ServiceId for " + recipient.getId()); if (recipient.isRegistered()) {
Log.w(TAG, "[getIdentityRecord] No ServiceId for registered user " + recipient.getId(), new Throwable());
} else {
Log.d(TAG, "[getIdentityRecord] No ServiceId for unregistered user " + recipient.getId());
}
return Optional.empty(); return Optional.empty();
} }
} }
@ -183,7 +187,11 @@ public class SignalBaseIdentityKeyStore {
records.add(record.toIdentityRecord(recipient.getId())); records.add(record.toIdentityRecord(recipient.getId()));
} }
} else { } else {
Log.w(TAG, "[getIdentityRecords] No serviceId for " + recipient.getId()); if (recipient.isRegistered()) {
Log.w(TAG, "[getIdentityRecords] No serviceId for registered user " + recipient.getId(), new Throwable());
} else {
Log.d(TAG, "[getIdentityRecords] No serviceId for unregistered user " + recipient.getId());
}
} }
} }
@ -196,7 +204,7 @@ public class SignalBaseIdentityKeyStore {
if (recipient.hasServiceId()) { if (recipient.hasServiceId()) {
cache.setApproval(recipient.requireServiceId().toString(), recipientId, nonBlockingApproval); cache.setApproval(recipient.requireServiceId().toString(), recipientId, nonBlockingApproval);
} else { } else {
Log.w(TAG, "[setApproval] No serviceId for " + recipient.getId()); Log.w(TAG, "[setApproval] No serviceId for " + recipient.getId(), new Throwable());
} }
} }
@ -206,7 +214,7 @@ public class SignalBaseIdentityKeyStore {
if (recipient.hasServiceId()) { if (recipient.hasServiceId()) {
cache.setVerified(recipient.requireServiceId().toString(), recipientId, identityKey, verifiedStatus); cache.setVerified(recipient.requireServiceId().toString(), recipientId, identityKey, verifiedStatus);
} else { } else {
Log.w(TAG, "[setVerified] No serviceId for " + recipient.getId()); Log.w(TAG, "[setVerified] No serviceId for " + recipient.getId(), new Throwable());
} }
} }