empathicqubit/Signal-Android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Add group update paging feature flag.

Browse source
This commit is contained in:
Cody Henthorne 2022-01-05 10:18:49 -05:00 • committed by Alex Hart
parent ee48a1ae25
commit 4dae424a5c
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/org/thoughtcrime/securesms/groups/v2/processing/GroupsV2StateProcessor.java
View file

@ -194,7 +194,7 @@ public final class GroupsV2StateProcessor {
if (inputGroupState == null) { if (inputGroupState == null) {
try { try {
if (FeatureFlags.internalUser()) { if (FeatureFlags.groupsV2UpdatePaging()) {
return updateLocalGroupFromServerPaged(revision, localState, timestamp); return updateLocalGroupFromServerPaged(revision, localState, timestamp);
} else { } else {
boolean latestRevisionOnly = revision == LATEST && (localState == null || localState.getRevision() == GroupsV2StateProcessor.RESTORE_PLACEHOLDER_REVISION); boolean latestRevisionOnly = revision == LATEST && (localState == null || localState.getRevision() == GroupsV2StateProcessor.RESTORE_PLACEHOLDER_REVISION);

12
app/src/main/java/org/thoughtcrime/securesms/util/FeatureFlags.java
View file

@ -88,6 +88,7 @@ public final class FeatureFlags {
private static final String DONOR_BADGES_DISPLAY = "android.donorBadges.display.4"; private static final String DONOR_BADGES_DISPLAY = "android.donorBadges.display.4";
private static final String CDSH = "android.cdsh"; private static final String CDSH = "android.cdsh";
private static final String VOICE_NOTE_RECORDING_V2 = "android.voiceNoteRecordingV2.2"; private static final String VOICE_NOTE_RECORDING_V2 = "android.voiceNoteRecordingV2.2";
private static final String GROUPS_V2_UPDATE_PAGING = "android.groupsv2.updatePaging";
/** /**
* We will only store remote values for flags in this set. If you want a flag to be controllable * We will only store remote values for flags in this set. If you want a flag to be controllable
@ -129,7 +130,8 @@ public final class FeatureFlags {
DONOR_BADGES, DONOR_BADGES,
DONOR_BADGES_DISPLAY, DONOR_BADGES_DISPLAY,
CHANGE_NUMBER_ENABLED, CHANGE_NUMBER_ENABLED,
VOICE_NOTE_RECORDING_V2 VOICE_NOTE_RECORDING_V2,
GROUPS_V2_UPDATE_PAGING
); );
@VisibleForTesting @VisibleForTesting
@ -184,7 +186,8 @@ public final class FeatureFlags {
SENDER_KEY_MAX_AGE, SENDER_KEY_MAX_AGE,
DONOR_BADGES_DISPLAY, DONOR_BADGES_DISPLAY,
DONATE_MEGAPHONE, DONATE_MEGAPHONE,
VOICE_NOTE_RECORDING_V2 VOICE_NOTE_RECORDING_V2,
GROUPS_V2_UPDATE_PAGING
); );
/** /**
@ -435,6 +438,11 @@ public final class FeatureFlags {
return getBoolean(VOICE_NOTE_RECORDING_V2, false); return getBoolean(VOICE_NOTE_RECORDING_V2, false);
} }
/** Whether or not to use the proper paging when updating group state. */
public static boolean groupsV2UpdatePaging() {
return getBoolean(GROUPS_V2_UPDATE_PAGING, false);
}
/** Only for rendering debug info. */ /** Only for rendering debug info. */
public static synchronized @NonNull Map<String, Object> getMemoryValues() { public static synchronized @NonNull Map<String, Object> getMemoryValues() {
return new TreeMap<>(REMOTE_VALUES); return new TreeMap<>(REMOTE_VALUES);