From 57b9571d86ae7b40823788fed1eb177d883d85c8 Mon Sep 17 00:00:00 2001
From: Greyson Parrelli <greyson@signal.org>
Date: Fri, 25 Aug 2023 14:34:54 -0400
Subject: [PATCH] Don't store blank usernames.

---
 .../org/thoughtcrime/securesms/keyvalue/AccountValues.kt | 9 ++++++++-
 .../migrations/CopyUsernameToSignalStoreMigrationJob.kt  | 2 +-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/org/thoughtcrime/securesms/keyvalue/AccountValues.kt b/app/src/main/java/org/thoughtcrime/securesms/keyvalue/AccountValues.kt
index 86addb46ed..9020f22fac 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/keyvalue/AccountValues.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/keyvalue/AccountValues.kt
@@ -362,7 +362,14 @@ internal class AccountValues internal constructor(store: KeyValueStore) : Signal
     get() = !isPrimaryDevice
 
   /** The local user's full username (nickname.discriminator), if set. */
-  var username: String? by stringValue(KEY_USERNAME, null)
+  var username: String?
+    get() {
+      val value = getString(KEY_USERNAME, null)
+      return if (value.isNullOrBlank()) null else value
+    }
+    set(value) {
+      putString(KEY_USERNAME, value)
+    }
 
   /** The local user's username link components, if set. */
   var usernameLink: UsernameLinkComponents?
diff --git a/app/src/main/java/org/thoughtcrime/securesms/migrations/CopyUsernameToSignalStoreMigrationJob.kt b/app/src/main/java/org/thoughtcrime/securesms/migrations/CopyUsernameToSignalStoreMigrationJob.kt
index 81aef555ba..0eb6e23530 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/migrations/CopyUsernameToSignalStoreMigrationJob.kt
+++ b/app/src/main/java/org/thoughtcrime/securesms/migrations/CopyUsernameToSignalStoreMigrationJob.kt
@@ -32,7 +32,7 @@ internal class CopyUsernameToSignalStoreMigrationJob(
 
     val self = Recipient.self()
 
-    if (self.username.isEmpty) {
+    if (self.username.isEmpty || self.username.get().isBlank()) {
       Log.i(TAG, "No username set, skipping.")
       return
     }