empathicqubit/Signal-Android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Remove check in SignalCallLinkRecord.

Browse source
This commit is contained in:
Alex Hart 2024-10-21 16:08:23 -03:00 • committed by Greyson Parrelli
parent 85f92e509a
commit 58f820d640
2 changed files with 0 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
app/src/test/java/org/thoughtcrime/securesms/storage/CallLinkRecordProcessorTest.kt
View file

@ -8,7 +8,6 @@ package org.thoughtcrime.securesms.storage
import okio.ByteString.Companion.EMPTY
import okio.ByteString.Companion.toByteString
import org.junit.Assert.assertFalse
import org.junit.Assert.assertThrows
import org.junit.BeforeClass
import org.junit.Test
import org.signal.core.util.logging.Log
@ -74,20 +73,6 @@ class CallLinkRecordProcessorTest {
assertFalse(result)
}
@Test
fun `Given a proto with both an admin pass key and a deletion timestamp, assert invalid`() {
// GIVEN
val proto = CallLinkRecord.Builder().apply {
rootKey = mockCredentials.linkKeyBytes.toByteString()
adminPasskey = mockCredentials.adminPassBytes!!.toByteString()
deletedAtTimestampMs = System.currentTimeMillis()
}.build()
assertThrows(IllegalStateException::class.java) {
SignalCallLinkRecord(STORAGE_ID, proto)
}
}
@Test
fun `Given a proto with neither an admin pass key nor a deletion timestamp, assert valid`() {
// GIVEN

6
libsignal-service/src/main/java/org/whispersystems/signalservice/api/storage/SignalCallLinkRecord.kt
View file

@ -19,12 +19,6 @@ class SignalCallLinkRecord(private val id: StorageId, private val proto: CallLin
val adminPassKey: ByteArray = proto.adminPasskey.toByteArray()
val deletionTimestamp: Long = proto.deletedAtTimestampMs
init {
if (deletionTimestamp != 0L && adminPassKey.isNotEmpty()) {
throw IllegalStateException("Cannot have nonzero deletion timestamp ($deletionTimestamp) and admin passkey!")
}
}
fun toProto(): CallLinkRecord {
return proto
}