empathicqubit/Signal-Android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Ensure bitmaps are not recycled when getting them from the cache.

Browse source
This commit is contained in:
Alex Hart 2023-07-10 17:08:27 -03:00 • committed by GitHub
parent 5fbf0a98b9
commit 61cd9767c8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
app/src/main/java/org/thoughtcrime/securesms/wallpaper/UriChatWallpaper.java
View file

@ -13,6 +13,7 @@ import androidx.annotation.NonNull;
import androidx.annotation.Nullable; import androidx.annotation.Nullable;
import com.bumptech.glide.load.DataSource; import com.bumptech.glide.load.DataSource;
import com.bumptech.glide.load.engine.DiskCacheStrategy;
import com.bumptech.glide.load.engine.GlideException; import com.bumptech.glide.load.engine.GlideException;
import com.bumptech.glide.request.RequestListener; import com.bumptech.glide.request.RequestListener;
import com.bumptech.glide.request.target.Target; import com.bumptech.glide.request.target.Target;
@ -64,14 +65,16 @@ final class UriChatWallpaper implements ChatWallpaper, Parcelable {
@Override @Override
public void loadInto(@NonNull ImageView imageView) { public void loadInto(@NonNull ImageView imageView) {
Bitmap cached = CACHE.get(uri); Bitmap cached = CACHE.get(uri);
if (cached != null) { if (cached != null && !cached.isRecycled()) {
Log.d(TAG, "Using cached value."); Log.d(TAG, "Using cached value.");
imageView.setImageBitmap(CACHE.get(uri)); imageView.setImageBitmap(cached);
} else { } else {
Log.d(TAG, "Not in cache. Fetching using Glide."); Log.d(TAG, "Not in cache or recycled. Fetching using Glide.");
GlideApp.with(imageView) GlideApp.with(imageView.getContext().getApplicationContext())
.asBitmap() .asBitmap()
.load(new DecryptableStreamUriLoader.DecryptableUri(uri)) .load(new DecryptableStreamUriLoader.DecryptableUri(uri))
.skipMemoryCache(true)
.diskCacheStrategy(DiskCacheStrategy.NONE)
.addListener(new RequestListener<>() { .addListener(new RequestListener<>() {
@Override @Override
public boolean onLoadFailed(@Nullable GlideException e, Object model, Target<Bitmap> target, boolean isFirstResource) { public boolean onLoadFailed(@Nullable GlideException e, Object model, Target<Bitmap> target, boolean isFirstResource) {
@ -94,16 +97,18 @@ final class UriChatWallpaper implements ChatWallpaper, Parcelable {
@Override @Override
public boolean prefetch(@NonNull Context context, long maxWaitTime) { public boolean prefetch(@NonNull Context context, long maxWaitTime) {
Bitmap cached = CACHE.get(uri); Bitmap cached = CACHE.get(uri);
if (cached != null) { if (cached != null && !cached.isRecycled()) {
Log.d(TAG, "Already cached, skipping prefetch."); Log.d(TAG, "Already cached, skipping prefetch.");
return true; return true;
} }
long startTime = System.currentTimeMillis(); long startTime = System.currentTimeMillis();
try { try {
Bitmap bitmap = GlideApp.with(context) Bitmap bitmap = GlideApp.with(context.getApplicationContext())
.asBitmap() .asBitmap()
.load(new DecryptableStreamUriLoader.DecryptableUri(uri)) .load(new DecryptableStreamUriLoader.DecryptableUri(uri))
.skipMemoryCache(true)
.diskCacheStrategy(DiskCacheStrategy.NONE)
.submit() .submit()
.get(maxWaitTime, TimeUnit.MILLISECONDS); .get(maxWaitTime, TimeUnit.MILLISECONDS);