From 6fa2a0f4116a9ec229eb3f0ef64cb8d740843412 Mon Sep 17 00:00:00 2001 From: Alex Hart Date: Tue, 26 May 2020 16:34:11 -0300 Subject: [PATCH] Polish UX for groups v2 management. --- app/src/main/AndroidManifest.xml | 3 +- .../ui/managegroup/ManageGroupFragment.java | 5 +- .../CustomNotificationsDialogFragment.java | 12 +-- .../profiles/edit/EditProfileFragment.java | 1 + .../custom_notifications_dialog_fragment.xml | 6 +- .../main/res/layout/group_manage_fragment.xml | 101 +++++++++++------- .../res/layout/group_recipient_list_item.xml | 4 +- app/src/main/res/values/strings.xml | 1 + app/src/main/res/values/styles.xml | 6 ++ 9 files changed, 89 insertions(+), 50 deletions(-) diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 59ad5b15a5..1c7ff7384f 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -258,6 +258,7 @@ android:theme="@style/TextSecure.LightNoActionBar" /> + android:windowSoftInputMode="stateVisible|adjustResize" /> addMembers.setVisibility(canEdit ? View.VISIBLE : View.GONE)); groupMemberList.setRecipientClickListener(recipient -> RecipientBottomSheetDialogFragment.create(recipient.getId(), groupId).show(requireFragmentManager(), "BOTTOM")); + groupMemberList.setOverScrollMode(View.OVER_SCROLL_NEVER); final CompoundButton.OnCheckedChangeListener muteSwitchListener = (buttonView, isChecked) -> { if (isChecked) { diff --git a/app/src/main/java/org/thoughtcrime/securesms/groups/ui/notifications/CustomNotificationsDialogFragment.java b/app/src/main/java/org/thoughtcrime/securesms/groups/ui/notifications/CustomNotificationsDialogFragment.java index fc89d1d013..315ca680f5 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/groups/ui/notifications/CustomNotificationsDialogFragment.java +++ b/app/src/main/java/org/thoughtcrime/securesms/groups/ui/notifications/CustomNotificationsDialogFragment.java @@ -12,11 +12,11 @@ import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; import android.widget.CompoundButton; -import android.widget.Switch; import android.widget.TextView; import androidx.annotation.NonNull; import androidx.annotation.Nullable; +import androidx.appcompat.widget.SwitchCompat; import androidx.appcompat.widget.Toolbar; import androidx.fragment.app.DialogFragment; import androidx.lifecycle.ViewModelProviders; @@ -32,11 +32,11 @@ public class CustomNotificationsDialogFragment extends DialogFragment { private static final String ARG_GROUP_ID = "group_id"; - private Switch customNotificationsSwitch; - private View soundLabel; - private TextView soundSelector; - private View vibrateLabel; - private Switch vibrateSwitch; + private SwitchCompat customNotificationsSwitch; + private View soundLabel; + private TextView soundSelector; + private View vibrateLabel; + private SwitchCompat vibrateSwitch; private CustomNotificationsViewModel viewModel; diff --git a/app/src/main/java/org/thoughtcrime/securesms/profiles/edit/EditProfileFragment.java b/app/src/main/java/org/thoughtcrime/securesms/profiles/edit/EditProfileFragment.java index ed9e320958..2b3a33ab65 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/profiles/edit/EditProfileFragment.java +++ b/app/src/main/java/org/thoughtcrime/securesms/profiles/edit/EditProfileFragment.java @@ -244,6 +244,7 @@ public class EditProfileFragment extends Fragment { if (isEditingGroup) { givenName.setHint(R.string.EditProfileFragment__group_name); + givenName.requestFocus(); toolbar.setTitle(R.string.EditProfileFragment__edit_group_name_and_photo); preview.setVisibility(View.GONE); familyName.setVisibility(View.GONE); diff --git a/app/src/main/res/layout/custom_notifications_dialog_fragment.xml b/app/src/main/res/layout/custom_notifications_dialog_fragment.xml index 56ccf44188..9dd776fb7f 100644 --- a/app/src/main/res/layout/custom_notifications_dialog_fragment.xml +++ b/app/src/main/res/layout/custom_notifications_dialog_fragment.xml @@ -10,7 +10,6 @@ android:layout_width="0dp" android:layout_height="?attr/actionBarSize" app:layout_constraintEnd_toEndOf="parent" - app:layout_constraintEnd_toStartOf="@id/custom_notifications_enable_switch" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" app:navigationIcon="@drawable/ic_arrow_left_24" @@ -59,7 +58,7 @@ app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@id/custom_notifications_sound_label" /> - - + app:layout_scrollFlags="scroll|exitUntilCollapsed" + app:scrimAnimationDuration="200"> @@ -78,13 +77,21 @@ android:layout_width="match_parent" android:layout_height="wrap_content"> + + + app:layout_constraintTop_toBottomOf="@id/divider"> + android:textAppearance="@style/Signal.Text.Body" /> @@ -121,10 +128,10 @@ + android:focusable="true"> - @@ -205,7 +213,7 @@ android:layout_height="match_parent" android:layout_weight="1" android:gravity="center_vertical|end" - android:textAppearance="@style/TextAppearance.Signal.Body2" + android:textAppearance="@style/Signal.Text.Body" android:textColor="@color/ultramarine_text_button" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" @@ -221,45 +229,66 @@ - + +