diff --git a/app/src/main/java/org/thoughtcrime/securesms/attachments/PointerAttachment.java b/app/src/main/java/org/thoughtcrime/securesms/attachments/PointerAttachment.java index 21cc8efd2f..0c3f80e526 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/attachments/PointerAttachment.java +++ b/app/src/main/java/org/thoughtcrime/securesms/attachments/PointerAttachment.java @@ -113,7 +113,7 @@ public class PointerAttachment extends Attachment { pointer.get().asPointer().getRemoteId().toString(), encodedKey, null, pointer.get().asPointer().getDigest().orElse(null), - pointer.get().asPointer().getincrementalDigest().orElse(null), + pointer.get().asPointer().getIncrementalDigest().orElse(null), fastPreflightId, pointer.get().asPointer().getVoiceNote(), pointer.get().asPointer().isBorderless(), @@ -139,7 +139,7 @@ public class PointerAttachment extends Attachment { thumbnail != null && thumbnail.asPointer().getKey() != null ? Base64.encodeBytes(thumbnail.asPointer().getKey()) : null, null, thumbnail != null ? thumbnail.asPointer().getDigest().orElse(null) : null, - thumbnail != null ? thumbnail.asPointer().getincrementalDigest().orElse(null) : null, + thumbnail != null ? thumbnail.asPointer().getIncrementalDigest().orElse(null) : null, null, false, false, @@ -169,7 +169,7 @@ public class PointerAttachment extends Attachment { thumbnail != null && thumbnail.asPointer().getKey() != null ? Base64.encodeBytes(thumbnail.asPointer().getKey()) : null, null, thumbnail != null ? thumbnail.asPointer().getDigest().orElse(null) : null, - thumbnail != null ? thumbnail.asPointer().getincrementalDigest().orElse(null) : null, + thumbnail != null ? thumbnail.asPointer().getIncrementalDigest().orElse(null) : null, null, false, false, diff --git a/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageReceiver.java b/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageReceiver.java index 48b537ede7..565f81fe4b 100644 --- a/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageReceiver.java +++ b/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageReceiver.java @@ -36,7 +36,6 @@ import org.whispersystems.signalservice.internal.util.concurrent.FutureTransform import org.whispersystems.signalservice.internal.util.concurrent.ListenableFuture; import org.whispersystems.signalservice.internal.websocket.ResponseMapper; -import java.io.ByteArrayOutputStream; import java.io.File; import java.io.FileInputStream; import java.io.IOException; @@ -154,7 +153,7 @@ public class SignalServiceMessageReceiver { if (!pointer.getDigest().isPresent()) throw new InvalidMessageException("No attachment digest!"); socket.retrieveAttachment(pointer.getCdnNumber(), pointer.getRemoteId(), destination, maxSizeBytes, listener); - return AttachmentCipherInputStream.createForAttachment(destination, pointer.getSize().orElse(0), pointer.getKey(), pointer.getDigest().get(), pointer.getincrementalDigest().orElse(new byte[0])); + return AttachmentCipherInputStream.createForAttachment(destination, pointer.getSize().orElse(0), pointer.getKey(), pointer.getDigest().get(), pointer.getIncrementalDigest().orElse(new byte[0])); } public InputStream retrieveSticker(byte[] packId, byte[] packKey, int stickerId) diff --git a/libsignal/service/src/main/java/org/whispersystems/signalservice/api/messages/SignalServiceAttachmentPointer.java b/libsignal/service/src/main/java/org/whispersystems/signalservice/api/messages/SignalServiceAttachmentPointer.java index 47d2b9bb5b..352b0107d7 100644 --- a/libsignal/service/src/main/java/org/whispersystems/signalservice/api/messages/SignalServiceAttachmentPointer.java +++ b/libsignal/service/src/main/java/org/whispersystems/signalservice/api/messages/SignalServiceAttachmentPointer.java @@ -111,7 +111,7 @@ public class SignalServiceAttachmentPointer extends SignalServiceAttachment { return digest; } - public Optional getincrementalDigest() { + public Optional getIncrementalDigest() { return incrementalDigest; } diff --git a/libsignal/service/src/main/java/org/whispersystems/signalservice/api/util/AttachmentPointerUtil.java b/libsignal/service/src/main/java/org/whispersystems/signalservice/api/util/AttachmentPointerUtil.java index 961704f477..dd1a3eadee 100644 --- a/libsignal/service/src/main/java/org/whispersystems/signalservice/api/util/AttachmentPointerUtil.java +++ b/libsignal/service/src/main/java/org/whispersystems/signalservice/api/util/AttachmentPointerUtil.java @@ -42,10 +42,13 @@ public final class AttachmentPointerUtil { .setContentType(attachment.getContentType()) .setKey(ByteString.copyFrom(attachment.getKey())) .setDigest(ByteString.copyFrom(attachment.getDigest().get())) - .setIncrementalDigest(ByteString.copyFrom(attachment.getincrementalDigest().get())) .setSize(attachment.getSize().get()) .setUploadTimestamp(attachment.getUploadTimestamp()); + if (attachment.getIncrementalDigest().isPresent()) { + builder.setIncrementalDigest(ByteString.copyFrom(attachment.getIncrementalDigest().get())); + } + if (attachment.getRemoteId().getV2().isPresent()) { builder.setCdnId(attachment.getRemoteId().getV2().get()); }