From 8ce914a344ee6edced169d74fe5bae1b81ed7b4a Mon Sep 17 00:00:00 2001 From: Moxie Marlinspike Date: Mon, 25 Sep 2017 08:32:45 -0700 Subject: [PATCH] Refactor media overview activity to display documents // FREEBIE --- AndroidManifest.xml | 1 + res/layout/media_overview_activity.xml | 49 ++- res/layout/media_overview_document_item.xml | 32 ++ ...> media_overview_document_item_header.xml} | 4 +- .../media_overview_documents_fragment.xml | 22 ++ .../media_overview_gallery_fragment.xml | 23 ++ ...em.xml => media_overview_gallery_item.xml} | 0 .../media_overview_gallery_item_header.xml | 18 + res/menu/media_overview.xml | 3 +- res/values/attrs.xml | 6 + res/values/strings.xml | 3 + res/values/themes.xml | 12 + .../securesms/MediaDocumentsAdapter.java | 132 ++++++++ ...aAdapter.java => MediaGalleryAdapter.java} | 10 +- .../securesms/MediaOverviewActivity.java | 311 +++++++++++------- .../RecipientPreferenceActivity.java | 2 +- .../securesms/database/MediaDatabase.java | 20 +- .../loaders/BucketedThreadMediaLoader.java | 2 +- .../database/loaders/ThreadMediaLoader.java | 9 +- 19 files changed, 504 insertions(+), 155 deletions(-) create mode 100644 res/layout/media_overview_document_item.xml rename res/layout/{media_overview_item_header.xml => media_overview_document_item_header.xml} (82%) create mode 100644 res/layout/media_overview_documents_fragment.xml create mode 100644 res/layout/media_overview_gallery_fragment.xml rename res/layout/{media_overview_item.xml => media_overview_gallery_item.xml} (100%) create mode 100644 res/layout/media_overview_gallery_item_header.xml create mode 100644 src/org/thoughtcrime/securesms/MediaDocumentsAdapter.java rename src/org/thoughtcrime/securesms/{MediaAdapter.java => MediaGalleryAdapter.java} (92%) diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 0d746d0fcf..e582825b66 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -314,6 +314,7 @@ android:configChanges="touchscreen|keyboard|keyboardHidden|orientation|screenLayout|screenSize"/> diff --git a/res/layout/media_overview_activity.xml b/res/layout/media_overview_activity.xml index e1aa997ce8..89303486c4 100644 --- a/res/layout/media_overview_activity.xml +++ b/res/layout/media_overview_activity.xml @@ -1,24 +1,39 @@ + - + + + android:layout_height="?android:attr/actionBarSize" + android:background="?attr/media_overview_toolbar_background" + android:titleTextColor="?attr/media_overview_toolbar_foreground" + android:foreground="?attr/media_overview_toolbar_foreground" + app:layout_scrollFlags="scroll|enterAlways"/> - + + + + + app:layout_behavior="@string/appbar_scrolling_view_behavior"/> - - - + diff --git a/res/layout/media_overview_document_item.xml b/res/layout/media_overview_document_item.xml new file mode 100644 index 0000000000..aaa04ca1aa --- /dev/null +++ b/res/layout/media_overview_document_item.xml @@ -0,0 +1,32 @@ + + + + + + + + \ No newline at end of file diff --git a/res/layout/media_overview_item_header.xml b/res/layout/media_overview_document_item_header.xml similarity index 82% rename from res/layout/media_overview_item_header.xml rename to res/layout/media_overview_document_item_header.xml index 3bc02d6cb5..6766df9c87 100644 --- a/res/layout/media_overview_item_header.xml +++ b/res/layout/media_overview_document_item_header.xml @@ -3,14 +3,14 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="@color/white" + android:background="?attr/media_overview_toolbar_background" android:padding="16dp"> + + + + + + + diff --git a/res/layout/media_overview_gallery_fragment.xml b/res/layout/media_overview_gallery_fragment.xml new file mode 100644 index 0000000000..24194589bd --- /dev/null +++ b/res/layout/media_overview_gallery_fragment.xml @@ -0,0 +1,23 @@ + + + + + + + + diff --git a/res/layout/media_overview_item.xml b/res/layout/media_overview_gallery_item.xml similarity index 100% rename from res/layout/media_overview_item.xml rename to res/layout/media_overview_gallery_item.xml diff --git a/res/layout/media_overview_gallery_item_header.xml b/res/layout/media_overview_gallery_item_header.xml new file mode 100644 index 0000000000..6766df9c87 --- /dev/null +++ b/res/layout/media_overview_gallery_item_header.xml @@ -0,0 +1,18 @@ + + + + + \ No newline at end of file diff --git a/res/menu/media_overview.xml b/res/menu/media_overview.xml index e860d756e0..9e99f02add 100644 --- a/res/menu/media_overview.xml +++ b/res/menu/media_overview.xml @@ -3,6 +3,5 @@ xmlns:app="http://schemas.android.com/apk/res-auto"> + app:showAsAction="never"/> diff --git a/res/values/attrs.xml b/res/values/attrs.xml index 1374635526..b8f043cc45 100644 --- a/res/values/attrs.xml +++ b/res/values/attrs.xml @@ -130,6 +130,12 @@ + + + + + + diff --git a/res/values/strings.xml b/res/values/strings.xml index c12f1bb47f..38e9c93340 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -1473,6 +1473,9 @@ Yesterday This week This month + Media + Documents + No documents found diff --git a/res/values/themes.xml b/res/values/themes.xml index c90d95b9c9..f392753adb 100644 --- a/res/values/themes.xml +++ b/res/values/themes.xml @@ -20,6 +20,12 @@ @color/background_material_light @drawable/preference_divider_light @style/PreferenceThemeOverlay.Fix + + @color/white + @color/gray70 + @color/gray50 + @color/gray70 + @color/white