From a504c9dd5621110e92063c221023341fb0b7f315 Mon Sep 17 00:00:00 2001 From: Greyson Parrelli Date: Mon, 6 Jan 2025 11:49:16 -0500 Subject: [PATCH] Fix overflow handling in condensed mode. --- .../securesms/conversation/ConversationItem.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationItem.java b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationItem.java index 7220807543..16c7494cb7 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationItem.java +++ b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationItem.java @@ -992,7 +992,11 @@ public final class ConversationItem extends RelativeLayout implements BindableCo } private boolean hasExtraText(MessageRecord messageRecord) { - return MessageRecordUtil.hasExtraText(messageRecord) || (!messageRecord.isDisplayBodyEmpty(context) && isContentCondensed()); + return MessageRecordUtil.hasExtraText(messageRecord); + } + + private boolean hasCondensedContent(MessageRecord messageRecord) { + return !messageRecord.isDisplayBodyEmpty(context) && isContentCondensed(); } private boolean hasQuote(MessageRecord messageRecord) { @@ -1067,6 +1071,7 @@ public final class ConversationItem extends RelativeLayout implements BindableCo } if (isContentCondensed()) { + bodyText.setOverflowText(getLongMessageSpan(messageRecord)); bodyText.setMaxLines(CONDENSED_MODE_MAX_LINES); } else { bodyText.setMaxLines(Integer.MAX_VALUE); @@ -1329,7 +1334,7 @@ public final class ConversationItem extends RelativeLayout implements BindableCo mediaThumbnailStub.require().setPlayVideoClickListener(playVideoClickListener); mediaThumbnailStub.require().setOnLongClickListener(passthroughClickListener); mediaThumbnailStub.require().setOnClickListener(passthroughClickListener); - mediaThumbnailStub.require().showShade(messageRecord.isDisplayBodyEmpty(getContext()) && !hasExtraText(messageRecord)); + mediaThumbnailStub.require().showShade(messageRecord.isDisplayBodyEmpty(getContext()) && !hasExtraText(messageRecord) && !hasCondensedContent(messageRecord)); mediaThumbnailStub.require().setImageResource(requestManager, thumbnailSlides, showControls, @@ -1521,7 +1526,7 @@ public final class ConversationItem extends RelativeLayout implements BindableCo topEnd = 0; } - if (hasLinkPreview(messageRecord) || hasExtraText(messageRecord)) { + if (hasLinkPreview(messageRecord) || hasExtraText(messageRecord) || hasCondensedContent(messageRecord)) { bottomStart = 0; bottomEnd = 0; }