From b58cede072fdeaf8eb2d4f07069ad1c5e1ff5c41 Mon Sep 17 00:00:00 2001 From: Greyson Parrelli Date: Wed, 18 Aug 2021 10:00:53 -0400 Subject: [PATCH] Fix issue with date header ID generation. We render based on the date received, but were generating the ID with the date sent. This caused the potential for a weird caching bug that could cause us to render the wrong date. --- .../securesms/conversation/ConversationAdapter.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationAdapter.java b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationAdapter.java index 528a665d3e..75da60b2fb 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationAdapter.java +++ b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationAdapter.java @@ -16,7 +16,6 @@ */ package org.thoughtcrime.securesms.conversation; -import android.animation.ValueAnimator; import android.annotation.SuppressLint; import android.content.Context; import android.view.LayoutInflater; @@ -69,7 +68,6 @@ import java.security.MessageDigest; import java.security.NoSuchAlgorithmException; import java.util.ArrayList; import java.util.Calendar; -import java.util.Date; import java.util.HashSet; import java.util.Iterator; import java.util.List; @@ -347,8 +345,8 @@ public class ConversationAdapter if (conversationMessage == null) return -1; - calendar.setTime(new Date(conversationMessage.getMessageRecord().getDateSent())); - return Util.hashCode(calendar.get(Calendar.YEAR), calendar.get(Calendar.DAY_OF_YEAR)); + calendar.setTimeInMillis(conversationMessage.getMessageRecord().getDateReceived()); + return calendar.get(Calendar.YEAR) * 1000L + calendar.get(Calendar.DAY_OF_YEAR); } @Override