empathicqubit/Signal-Android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Ensure Job factories pass the parameters to their created Jobs.

Browse source
This commit is contained in:
Alan Evans 2021-03-16 10:07:21 -03:00
parent 8f26d63d6f
commit d83c3d35eb
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/src/main/java/org/thoughtcrime/securesms/jobmanager/JobInstantiator.java
View file

@ -14,8 +14,15 @@ class JobInstantiator {
}
public @NonNull Job instantiate(@NonNull String jobFactoryKey, @NonNull Job.Parameters parameters, @NonNull Data data) {
if (jobFactories.containsKey(jobFactoryKey)) {
return jobFactories.get(jobFactoryKey).create(parameters, data);
Job.Factory factory = jobFactories.get(jobFactoryKey);
if (factory != null) {
Job job = factory.create(parameters, data);
if (!job.getId().equals(parameters.getId())) {
throw new AssertionError("Parameters not supplied to job during creation");
}
return job;
} else {
throw new IllegalStateException("Tried to instantiate a job with key '" + jobFactoryKey + "', but no matching factory was found.");
}