empathicqubit/Signal-Android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Don't use ConnectivityManager checkRouteToHost for IPv6

Browse source 
T-Mobile LTE now uses IPv6 addresses for their MMSC, which are
incompatible with ConnectivityManager's checkRouteToHost.
This commit is contained in:
Moxie Marlinspike 2013-07-12 15:25:34 -07:00
parent bccf4895f6
commit dfa710a6fc
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/org/thoughtcrime/securesms/mms/MmsCommunication.java
View file

@ -148,15 +148,17 @@ public class MmsCommunication {
return;
}
Log.w("MmsCommunication", "Checking route to address: " + host + " , " + inetAddress.getHostAddress());
byte[] ipAddressBytes = inetAddress.getAddress();
if (ipAddressBytes != null && ipAddressBytes.length == 4) {
int ipAddress = Conversions.byteArrayToIntLittleEndian(ipAddressBytes, 0);
ConnectivityManager manager = (ConnectivityManager)context.getSystemService(Context.CONNECTIVITY_SERVICE);
if (!manager.requestRouteToHost(MmsDownloader.TYPE_MOBILE_MMS, ipAddress))
throw new IOException("Connection manager could not obtain route to host.");
// if (!manager.requestRouteToHost(ConnectivityManager.TYPE_MOBILE, ipAddress))
// throw new IOException("Connection manager could not obtain route to host.");
}
}
protected static AndroidHttpClient constructHttpClient(Context context, MmsConnectionParameters mmsConfig) {