empathicqubit/vscode-vsce
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #139 from Microsoft/blockProposedApi

Browse source 
check for enableProposedApi and don't allow to publish
This commit is contained in:
João Moreno 2016-11-10 17:00:35 +01:00 • committed by GitHub
commit 79978813cb
3 changed files with 19 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/manifest.ts
View file

@ -22,6 +22,7 @@ export interface Manifest {
markdown?: 'github' | 'standard';
_bundling?: { [name: string]: string; }[];
_testing?: string;
enableProposedApi?: boolean;
// optional (npm)
author?: string | Person;

4
src/package.ts
View file

@ -432,6 +432,10 @@ export function validateManifest(manifest: Manifest): Manifest {
throw new Error('Manifest missing field: engines.vscode');
}
if (manifest.enableProposedApi) {
throw new Error('Extensions using proposed API (enableProposedApi: true) cannot be published');
}
return manifest;
}

11
src/test/package.test.ts
View file

@ -147,6 +147,17 @@ describe('validateManifest', () => {
assert.throws(() => { validateManifest({ publisher: 'demo', name: 'demo', version: '1.0.0', engines: null }); });
assert.throws(() => { validateManifest({ publisher: 'demo', name: 'demo', version: '1.0.0', engines: { vscode: null } }); });
});
it('should not allow proposed API', () => {
assert.throws(() => { validateManifest({ enableProposedApi: true, publisher: 'demo', name: 'demo', version: '1.0.0', engines: { vscode: '0.10.1' } }); });
assert.throws(() => { validateManifest({ enableProposedApi: <any>1, publisher: 'demo', name: 'demo', version: '1.0.0', engines: { vscode: '0.10.1' } }); });
let mani1: Manifest = { enableProposedApi: false, publisher: 'demo', name: 'demo', version: '1.0.0', engines: { vscode: '0.10.1' } };
assert.ok(validateManifest(mani1) === mani1);
let mani2: Manifest = { publisher: 'demo', name: 'demo', version: '1.0.0', engines: { vscode: '0.10.1' } };
assert.ok(validateManifest(mani2) === mani2);
});
});
describe('toVsixManifest', () => {