From e44511383c48a2e5442ed403917399c1ac5a0582 Mon Sep 17 00:00:00 2001 From: Joao Moreno Date: Tue, 17 Nov 2015 22:24:42 +0100 Subject: [PATCH] ignore **/.vsixmanifest fixes #42 --- src/package.ts | 3 ++- src/test/fixtures/vsixmanifest/ohno.vsixmanifest | 1 + src/test/fixtures/vsixmanifest/package.json | 6 ++++++ src/test/package.test.ts | 10 ++++++++++ 4 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 src/test/fixtures/vsixmanifest/ohno.vsixmanifest create mode 100644 src/test/fixtures/vsixmanifest/package.json diff --git a/src/package.ts b/src/package.ts index 9f8ba0a..ee1c35c 100644 --- a/src/package.ts +++ b/src/package.ts @@ -299,7 +299,8 @@ const defaultIgnore = [ '.vscodeignore', '**/.git/**', '**/*.vsix', - '**/.DS_Store' + '**/.DS_Store', + '**/*.vsixmanifest' ]; function devDependenciesIgnore(manifest: Manifest): string[] { diff --git a/src/test/fixtures/vsixmanifest/ohno.vsixmanifest b/src/test/fixtures/vsixmanifest/ohno.vsixmanifest new file mode 100644 index 0000000..69b3dc3 --- /dev/null +++ b/src/test/fixtures/vsixmanifest/ohno.vsixmanifest @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/src/test/fixtures/vsixmanifest/package.json b/src/test/fixtures/vsixmanifest/package.json new file mode 100644 index 0000000..9b0f426 --- /dev/null +++ b/src/test/fixtures/vsixmanifest/package.json @@ -0,0 +1,6 @@ +{ + "name": "uuid", + "publisher": "joaomoreno", + "version": "1.0.0", + "engines": { "vscode": "*" } +} \ No newline at end of file diff --git a/src/test/package.test.ts b/src/test/package.test.ts index 4331c9d..bd8f629 100644 --- a/src/test/package.test.ts +++ b/src/test/package.test.ts @@ -67,6 +67,16 @@ describe('collect', () => { assert.ok(!files.some(f => /fake\/dependency\.js/.test(f.path))); }); }); + + it('should ignore **/.vsixmanifest', () => { + const cwd = fixture('vsixmanifest'); + + return readManifest(cwd) + .then(manifest => collect(manifest, { cwd })) + .then(files => { + assert.equal(files.filter(f => /\.vsixmanifest$/.test(f.path)).length, 1); + }); + }); }); describe('validateManifest', () => {