empathicqubit/vscode-vsce
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fixes #415

Browse source
This commit is contained in:
Joao Moreno 2020-01-21 15:09:10 +01:00
parent 7eba451e35
commit e4a8df59d3
No known key found for this signature in database
GPG key ID: 9494F5E6167A8E6B
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/test/validation.test.ts
View file

@ -57,7 +57,6 @@ describe('validateVersion', () => {
it('should validate', () => { it('should validate', () => {
validateVersion('1.0.0'); validateVersion('1.0.0');
validateVersion('0.1.1'); validateVersion('0.1.1');
validateVersion('0.1.1-pre');
assert.throws(() => validateVersion('.')); assert.throws(() => validateVersion('.'));
assert.throws(() => validateVersion('..')); assert.throws(() => validateVersion('..'));
@ -66,6 +65,7 @@ describe('validateVersion', () => {
assert.throws(() => validateVersion('.0.1')); assert.throws(() => validateVersion('.0.1'));
assert.throws(() => validateVersion('0.1.')); assert.throws(() => validateVersion('0.1.'));
assert.throws(() => validateVersion('0.0.0.1')); assert.throws(() => validateVersion('0.0.0.1'));
assert.throws(() => validateVersion('0.1.1-pre'));
}); });
}); });

4
src/validation.ts
View file

@ -31,6 +31,10 @@ export function validateVersion(version: string): void {
if (!semver.valid(version)) { if (!semver.valid(version)) {
throw new Error(`Invalid extension version '${version}'`); throw new Error(`Invalid extension version '${version}'`);
} }
if (semver.prerelease(version)) {
throw new Error(`Invalid extension version '${version}: semver prerelease field is not supported`);
}
} }
export function validateEngineCompatibility(version: string): void { export function validateEngineCompatibility(version: string): void {